Skip to content

Pin pandas version for Python 3.9 in optional requirements for tests #5219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

emilykl
Copy link
Contributor

@emilykl emilykl commented Jun 5, 2025

For context: pandas-dev/pandas#61563 (comment)

TL;DR Pandas intended to drop support for Python 3.9 in the Pandas 2.3.0 release, and therefore didn’t upload pre-compiled wheels for Python 3.9; however, they forgot to update requires-python in the pyproject.toml, so uv still tries to install it and has to compile from scratch since the wheel isn’t available, which fails.

This fixes the failing Python 3.9 CI jobs on main.

@emilykl emilykl requested a review from gvwilson June 5, 2025 21:03
gvwilson added a commit that referenced this pull request Jun 6, 2025
-   Switch to `argparse` and clean up imports in `commands.py`.
-   Remove `requires-optional.txt` and `test_requirements/*`
    (put dependencies in `pyproject.toml` instead).
-   Remove `black` and use `ruff` instead.
-   Add `--noformat` option to `python commands.py codegen` for experimenting.
-   Pass output directory around to control what is formatted and linted.
-   Add `python commands.py format` to only do formatting.
-   Add `python commands.py lint` to check code.
-   Reformat comments in `codegen/*.py`.
-   Use double-quoted strings for (most) code generation.
-   Incorporate pandas version pinning from #5219.

Note:

1.  Only the generated code is formatted and linted:
    -   `plotly/validators/**/*.py`
    -   `plotly/graph_objs/**/*.py`
    -   `plotly/graph_objects/__init__.py`

2.  The strings in the data used by code generation are (for example)
    `"'some_name'"` (i.e., have embedded single quotes). This PR does
    not try to fix that: instead, we rely on reformatting to turn all
    the single-quoted strings into double-quoted strings.
@emilykl
Copy link
Contributor Author

emilykl commented Jun 6, 2025

Pandas team has uploaded wheels for 3.9 which resolves the issue in our pipeline, so I'm closing this PR.

@gvwilson You should revert the change in your PR as well.

@emilykl emilykl closed this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants